The Pragmatic Craftsman         :: Simplicity from complexity :: | About Me |

Most likely, it does. Here is an article, Why Your Code Sucks by Dave Astels that will tell you why it does. Read the article as I think it's great. After you read it, make sure you verify your code according to all of the points. Dave says that your code sucks if it meets the following criteria:

1. Your code sucks if it doesn't work.
2. Your code sucks if it isn't testable.
3. Your code sucks if it's hard to read.
4. Your code sucks if it's not understandable.
5. Your code sucks if it dogmatically conforms to a trendy framework at the cost of following good design/implementation practices.
6. Your code sucks if it has duplication.

So, I ask you, does your code suck?

I think some of the code that I write sucks because it isn't very easily testable. I think, though, that it is hard to test web applications and that's the main reason behind it. I'm trying to find an easy way to do that so I can eliminate it. I agree with the author, your code should be easily testable. As far as the other points are concerned, I would say that my code is easy to read, easy to understand, and it does not have any duplication. I take extra care in those areas.